Guard against non-numeric id in GeoJSON features #4581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#4494 reports that the issue didn't occur in v0.32.1. Were you able to confirm that and determine why? |
|
@jfirebaugh yep - v0.32.1 is the last release before cf031a6, which is when the geojson-vt wrapper started copying |
jfirebaugh
approved these changes
Apr 12, 2017
src/source/geojson_wrapper.js
Outdated
| @@ -17,8 +17,8 @@ class FeatureWrapper { | |||
| this.rawGeometry = feature.geometry; | |||
| } | |||
| this.properties = feature.tags; | |||
| if ('id' in feature) { | |||
| this.id = feature.id; | |||
| if ('id' in feature && !isNaN(feature.id)) { | |||
There was a problem hiding this comment.
Can you add a comment here explaining the original issue and the reason for !isNaN/parseInt?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4494
Since we're using the vector tile binary format even for geojson-vt tiles, make
sure we conform to the MVT requirement that
feature.idis an integer