Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make xhr request in getImage #1472

Merged
merged 1 commit into from
Sep 11, 2015
Merged

Make xhr request in getImage #1472

merged 1 commit into from
Sep 11, 2015

Conversation

edenh
Copy link
Contributor

@edenh edenh commented Sep 10, 2015

@jfirebaugh
Copy link
Contributor

Cool approach! Does this work in all the supported browsers?

jfirebaugh
jfirebaugh reviewed Sep 10, 2015
View reviewed changes
js/util/browser/ajax.js
}
img.onload = function() {
callback(null, img);
var xhr = new XMLHttpRequest();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use exports.getArrayBuffer internally here to avoid some code duplication.

@edenh
Copy link
Contributor Author

edenh commented Sep 11, 2015

Sprites are not being rendered in IE 11 with no errors despite good support for createObjectURL

EDIT: The page zoom was at 125%. At 100%, this patch works.

@edenh
Copy link
Contributor Author

edenh commented Sep 11, 2015

Ref #1475

@edenh edenh added this to the 0.11 milestone Sep 11, 2015
@jfirebaugh jfirebaugh merged commit 09c5e42 into master Sep 11, 2015
@jfirebaugh jfirebaugh deleted the binary-sprite-img branch September 11, 2015 21:52
@jfirebaugh jfirebaugh mentioned this pull request Dec 17, 2016
Closed
@mourner mourner mentioned this pull request Jul 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

setStyle does not re-fetch sprite image
3 participants
@edenh @jfirebaugh @mourner