Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align pattern vertex array with 4-byte boundary again #12361

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

mourner
Copy link
Member

@mourner mourner commented Nov 7, 2022

A follow-up to #12326, and an equivalent to the earlier #9681 (see there for the reasoning). Also might help with non-integer pixel ratios on data-driven pattern properties.

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'

@mourner mourner added the skip changelog Used for PRs that do not need a changelog entry label Nov 7, 2022
@mourner mourner marked this pull request as ready for review November 7, 2022 17:02
@mourner mourner requested a review from a team as a code owner November 7, 2022 17:02
@mourner
Copy link
Member Author

mourner commented Nov 8, 2022

@SnailBones for some reason, I can't merge this PR because it says ci/circleci: test-render-linux-chrome-dev Expected — Waiting for status to be reported, even though the new browser test setup isn't yet even merged — do you know what might be going on?

@SnailBones
Copy link
Contributor

@SnailBones for some reason, I can't merge this PR because it says ci/circleci: test-render-linux-chrome-dev Expected — Waiting for status to be reported, even though the new browser test setup isn't yet even merged — do you know what might be going on?

Yes, we changed the name of the test-render run to test-render-linux-chrome-dev to be more specific. It seems I was a bit hasty in updating the branch protection rules, I'll remove that requirement and re-add it after #12268 is merged.

@SnailBones SnailBones merged commit 25ae6fa into main Nov 8, 2022
@SnailBones SnailBones deleted the align-pattern-array branch November 8, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Used for PRs that do not need a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants