redo placement for geojson sources too #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I don't really like how the logic is spread out between source.js and tile.js... it would be nice to have a better way of sharing code between |
Yeah, it would. I'm also wondering how this would look once we "composite" sources and have only one tile pyramid. Do you have any ideas about how we would implement that? |
|
@jfirebaugh should we just merge this and refactor in follow-up PRs later? |
jfirebaugh
force-pushed
the
geojson-redo-placement
branch
2 times, most recently
from
ecda1a1
to
91fff36
Compare
jfirebaugh
force-pushed
the
geojson-redo-placement
branch
from
91fff36
to
d932579
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just realized it wasn't redoing placement for geojson layers.
A pretty short diff if you want to review @jfirebaugh, otherwise I'll just merge.