Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always retain raster tile cache control data #10494

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

andycalder
Copy link
Contributor

@andycalder andycalder commented Mar 22, 2021

This fixes #10491. It ensures that cache control headers are passed back from getImage() regardless of whether arrayBufferToImage() or arrayBufferToImageBitmap() is used internally.

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog' (I don't have privileges for this)
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Fixed a bug where raster tile expiry data was not being retained.</changelog>

Copy link
Contributor

@arindam1993 arindam1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @andycalder , I ran a quick test across Chrome, Firefox and Safari on macOS since they have varying ImageBitMap support and the caching behavior works as expected!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refreshExpiredTiles not working when offscreenCanvasSupported
2 participants