error when accessing style in a control's onRemove

[ansis]

If a map control calls a method that accesses the style in onRemove then an error is thrown and the map removal fails.

This is heavily related to #7477. Fixing it would fix the error here but we might want to move removing the controls to before the setStyle(null) here so that the onRemove has access to the style:

mapbox-gl-js/src/ui/map.js

Lines 1672 to 1679 in 42d1a5a

	this.setStyle(null);
	if (typeof window !== 'undefined') {
	window.removeEventListener('resize', this._onWindowResize, false);
	window.removeEventListener('online', this._onWindowOnline, false);
	}
	for (const control of this._controls) control.onRemove(this);
	this._controls = [];

mapbox-gl-js version: master

browser: all

Steps to Trigger Behavior

1. create a control
2. call a method that accesses the style in onRemove, for example map.getLayer("background")

Link to Demonstration

https://jsbin.com/tarecanedo/1/edit?html,output

Expected Behavior

Either:

• gets called before the style is destroyed and it returns the actual layer
• gets called after style is destroyed and it returns nothing
• gets called after the style is destroyed and triggers error event but not exception

Actual Behavior

Uncaught TypeError: Cannot read property 'getLayer' of undefined and map fails to remove.