Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text-pitch-alignment: viewport w/ text-rotation-alignment: map doesn't work for point features #4860

Closed
ChrisLoer opened this issue Jun 21, 2017 · 1 comment
Closed

text-pitch-alignment: viewport w/ text-rotation-alignment: map doesn't work for point features #4860

ChrisLoer opened this issue Jun 21, 2017 · 1 comment
Assignees
@ChrisLoer
Labels
bug 🐞

Comments

@ChrisLoer
Copy link
Contributor

For point features, if you set the pitch-alignment to viewport but the rotation-alignment to map, the label won't rotate with the map. Line features are fine.

My guess is this was introduced by #4781 -- it doesn't happen in v0.38.

I'll look into why.
@ChrisLoer ChrisLoer self-assigned this Jun 21, 2017
@ChrisLoer
Copy link
Contributor Author

/cc @ansis

ChrisLoer added a commit that referenced this issue Jun 21, 2017
@ChrisLoer
Fix issue #4860: apply map rotation to unpitched point labels.
78bb9dc
This was referenced Jun 21, 2017
Merged
Merged
ChrisLoer added a commit that referenced this issue Jun 22, 2017
@ChrisLoer
Fix issue #4860: apply map rotation to unpitched point labels.
581dd0f
@ChrisLoer ChrisLoer mentioned this issue Jul 7, 2017
Closed
ChrisLoer added a commit that referenced this issue Jul 7, 2017
@ChrisLoer
Re-enable native tests for pitched views.
12fde1b 
- Collision debug still needs to be ignored (#3841)
- GL JS Regression #4860 not fixed yet (#9456)
- Pitched symbol queries still have order discrepancies (#6817)
ChrisLoer added a commit that referenced this issue Jul 7, 2017
@ChrisLoer
Re-enable native tests for pitched views.
dfb4246 
- Collision debug still needs to be ignored (#3841)
- GL JS Regression #4860 not fixed yet (#9456)
- Pitched symbol queries still have order discrepancies (#6817)
ChrisLoer added a commit that referenced this issue Jul 11, 2017
@ChrisLoer
Enable native test for GL JS regression #4860.
d670d0a
@ChrisLoer ChrisLoer mentioned this issue Jul 11, 2017
Merged
ChrisLoer added a commit that referenced this issue Jul 11, 2017
@ChrisLoer
Enable native test for GL JS regression #4860.
4b82123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisLoer ChrisLoer

Labels
bug 🐞
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChrisLoer