Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Style#setGlyphs method #3625

Open
anandthakker opened this issue Nov 15, 2016 · 2 comments
Open

Add Style#setGlyphs method #3625

anandthakker opened this issue Nov 15, 2016 · 2 comments

Comments

@anandthakker
Copy link
Contributor

anandthakker commented Nov 15, 2016

Follows on to #3621: add setGlyphs and setSprite methods so that smart setStyle does not have to bail out and recreate the whole style when these properties change.

update: See also #2058

@lucaswoj
Copy link
Contributor

lucaswoj commented Nov 17, 2016

👍 Thanks for opening this ticket @anandthakker.

There are several open tickets about sprite enhancements. I'm going to think carefully about the interplay between them and whether or not any could be merged as duplicates of eachother

@anandthakker
Copy link
Contributor Author

Ah, I somehow missed #2058 in my search. In light of that one, I think it makes sense to rename this ticket to be only about Style#setGlyphs.

@anandthakker anandthakker changed the title Add Style#setGlyphs, Style#setSprite methods Add Style#setGlyphs method Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants