-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zooming in raster tile layers cause triggers a continues render loop #3398
Comments
Thanks for the report! Looks like a serious issue. |
This also prevents |
I think I found a second issue. After merging #3399 the loop with the _sourcesDirty flag was fixed but then it gets stuck in an a animation loop setting the _styleDirty flag. It appears to be related to #3532 and #3526. Specifically Tile.setAnimationLoop (https://github.com/mapbox/mapbox-gl-js/blob/master/js/source/tile.js#L44) is called every time the tile is rendered constantly extending the length of the animation. Hacking that not to reset the animation fixed the loop. However that led to a fade-in animation each time I zoom the map that is causing my raster overlay to flash. Is that how it is intended to work? Maybe I just need to set raster-fade-duration to zero on overlays? For now I'm just forcing it to zero. In case it helps, you can see my hack here: https://github.com/maphubs/mapbox-gl-js/commit/2d79f689a92f0efa1a3849c1b19540c597b8b1b1 |
I just noticed that this issue has significant performance impact when drawing. Related to #3812. |
This bug makes working with IE11 almost impossible as soon as you tilt the map. All these render cycles take a huge amount of time when the map is tilted. It's impossible to render geojson layers at this point. Please fix :) |
I have a similar problem but with a vector tile source. Could it be related: #3866 ? |
@stackTom can you reproduce it with a minimal test case (e.g. in a JSFiddle) on the latest master? If so, please report a new issue. |
To reproduce:
Create a map with a raster tile layer and listen for the
'render'
event. Then, Zoom out, then zoom in far.Expected behavior:
'render'
will eventually stop being emitted andmap.loaded()
returnstrue
.Actual behavior: render is emitted indefinitely and the loaded state of the map is never
true
.Here's also a GIF
The text was updated successfully, but these errors were encountered: