Ensure fills with transparent colors and patterns are rendered as exp…

…ected (#3120)

* Ensure fills with transparent colors and patterns are rendered as expected

* Remove all opacity checking from StyleLayer#isHidden

js/style/style_layer.js

@@ -218,8 +218,6 @@ StyleLayer.prototype = util.inherit(Evented, {
         if (this.minzoom && zoom < this.minzoom) return true;
         if (this.maxzoom && zoom >= this.maxzoom) return true;
         if (this.layout['visibility'] === 'none') return true;
-        if (this.isPaintValueFeatureConstant(this.type + '-opacity') && this.paint[this.type + '-opacity'] === 0) return true;
-        if (this.isPaintValueFeatureConstant(this.type + '-color') && this.paint[this.type + '-color'] && this.paint[this.type + '-color'][3] === 0) return true;
 
         return false;
     },

js/style/style_layer/fill_style_layer.js

@@ -47,24 +47,6 @@ FillStyleLayer.prototype = util.inherit(StyleLayer, {
         } else {
             return StyleLayer.prototype.isPaintValueZoomConstant.call(this, name);
         }
-    },
-
-    isHidden: function(zoom) {
-        if (this.minzoom && zoom < this.minzoom) return true;
-        if (this.maxzoom && zoom >= this.maxzoom) return true;
-        if (this.layout['visibility'] === 'none') return true;
-
-        var isFillHidden = (
-            (this.isPaintValueFeatureConstant('fill-opacity') && this.paint['fill-opacity'] === 0) ||
-            (this.isPaintValueFeatureConstant('fill-color') && this.paint['fill-color'][3] === 0)
-        );
-
-        var isOutlineHidden = (
-            this.isPaintValueFeatureConstant('fill-outline-color') &&
-            this.paint['fill-outline-color'][3] === 0
-        );
-
-        return isFillHidden && isOutlineHidden;
     }
 
 });

js/style/style_layer/symbol_style_layer.js

@@ -11,16 +11,6 @@ module.exports = SymbolStyleLayer;
 
 SymbolStyleLayer.prototype = util.inherit(StyleLayer, {
 
-    isHidden: function() {
-        if (StyleLayer.prototype.isHidden.apply(this, arguments)) return true;
-
-        var isTextHidden = this.paint['text-opacity'] === 0 || !this.layout['text-field'];
-        var isIconHidden = this.paint['icon-opacity'] === 0 || !this.layout['icon-image'];
-        if (isTextHidden && isIconHidden) return true;
-
-        return false;
-    },
-
     getLayoutValue: function(name, globalProperties, featureProperties) {
         if (name === 'text-rotation-alignment' &&
                 this.getLayoutValue('symbol-placement', globalProperties, featureProperties) === 'line' &&

package.json

@@ -60,7 +60,7 @@
     "jsdom": "^9.4.2",
     "json-loader": "^0.5.4",
     "lodash": "^4.13.1",
-    "mapbox-gl-test-suite": "mapbox/mapbox-gl-test-suite#35efbce663a0f13d37d34afac799e33178ee610a",
+    "mapbox-gl-test-suite": "mapbox/mapbox-gl-test-suite#333cf135f5358f48abd608a62787045a5f6fac0c",
     "memory-fs": "^0.3.0",
     "minifyify": "^7.0.1",
     "npm-run-all": "^3.0.0",