Throw ValidationError if required sprite property is not present

mapbox · Nov 2, 2018 · 11f929d · 11f929d
1 parent fc7703e
commit 11f929d
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/src/style-spec/validate/validate_property.js b/src/style-spec/validate/validate_property.js
@@ -13,6 +13,7 @@ export default function validateProperty(options, propertyType) {
     const value = options.value;
     const propertyKey = options.objectKey;
     const layerSpec = styleSpec[`${propertyType}_${options.layerType}`];
+    const propsThatRequireSprite = ['background-pattern', 'fill-pattern', 'fill-extrusion-pattern', 'line-pattern', 'icon-image'];
 
     if (!layerSpec) return [];
 
@@ -51,6 +52,12 @@ export default function validateProperty(options, propertyType) {
         }
     }
 
+    if (options.layerType === 'background' || options.layerType === 'fill' || options.layerType === 'fill-extrusion' || options.layerType === 'line' || options.layerType === 'symbol') {
+        if (propsThatRequireSprite.indexOf(propertyKey) > -1 && style && !style.sprite) {
+            errors.push(new ValidationError(key, value, `use of "${propertyKey}" requires a style "sprite" property`));
+        }
+    }
+
     return errors.concat(validate({
         key: options.key,
         value,