Modify error reporting for API >= 26 #472
Conversation
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
============================================
- Coverage 68.41% 68.26% -0.16%
- Complexity 394 397 +3
============================================
Files 69 70 +1
Lines 2159 2174 +15
Branches 172 172
============================================
+ Hits 1477 1484 +7
- Misses 584 591 +7
- Partials 98 99 +1 |
libtelemetry/src/full/java/com/mapbox/android/telemetry/MapboxTelemetry.java
Show resolved
Hide resolved
libtelemetry/src/full/java/com/mapbox/android/telemetry/crash/CrashReporter.java
Outdated
Show resolved
Hide resolved
libtelemetry/src/full/java/com/mapbox/android/telemetry/crash/CrashReporter.java
Outdated
Show resolved
Hide resolved
| crashReporter.sendErrorReports(); | ||
| } | ||
| }); | ||
| } catch (Throwable throwable) { |
There was a problem hiding this comment.
Might deserve a note that you are catching Throwable because we don't want the crash reporter to report it's own reporting errors:
|
@Guardiola31337 @pengdev I'd love your reviews from the Nav and Maps SDK sides, respectively. |
| * This is a background job that sends crash events to the telemetry endpoint | ||
| * at startup. | ||
| */ | ||
| public final class CrashReporterJobIntentService extends JobIntentService { |
There was a problem hiding this comment.
Noting that this is technically breaking SemVer as it's a public class which is not under internal
There was a problem hiding this comment.
@nkukday though they arrived after merging the PR - did you have a chance to address @Guardiola31337's comments, maybe as tail work?
| @@ -1,4 +1,4 @@ | |||
| package com.mapbox.android.telemetry.crash; | |||
There was a problem hiding this comment.
Noting that this is technically breaking Semver as packages of a public class changed
# Resolve Conflicts: # libtelemetry/src/androidTestFull/java/com/mapbox/android/telemetry/errors/ErrorReporterEngineInstrumentedTest.java # libtelemetry/src/full/java/com/mapbox/android/telemetry/MapboxTelemetry.java # libtelemetry/src/full/java/com/mapbox/android/telemetry/crash/CrashReporterJobIntentService.java
We are experiencing crashes within
JobIntentServiceon and above API 26. Linking the Google issue here. As a workaround, we will continue to useJobIntentServicebelow API 26 (Android O) and use a network request to report errors on or above API 26.