Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Multiple Formats in a Text Field #988

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Multiple Formats in a Text Field #988

merged 1 commit into from
Mar 11, 2019

Conversation

riastrad
Copy link
Contributor

@riastrad riastrad commented Mar 6, 2019

Resolves #985

This PR adds a new example that demonstrates how to to use multiple formats within a SymbolLayer's textField.

@riastrad riastrad self-assigned this Mar 6, 2019
@langsmith
Copy link
Contributor

@riastrad , https://docs.mapbox.com/mapbox-gl-js/example/display-and-style-rich-text-labels/ could be good to reference if you wanna' see how the expressions are used. All of these wild text label examples are basically more about setting default, fallbacks, etc. with expressions, than anything else.

@riastrad
Copy link
Contributor Author

riastrad commented Mar 7, 2019

@langsmith this basically done (let's say 98%). I'll be updating the example's menu card image tomorrow morning and then it should be good to merge 🚀

multiple-formats-screenshot

@langsmith
Copy link
Contributor

giphy

@riastrad
Copy link
Contributor Author

riastrad commented Mar 8, 2019

This should be good to go, @langsmith!

Also noting that I dropped this in a very similar location as the new example in #982, so whichever example merges second should gird itself for the probability of merge errors in MainActivity.java & AndroidManifest.xml.

@langsmith
Copy link
Contributor

Great work @riastrad . I pushed a commit, which imports some methods to improve the readability of the code, so that there are fewer instances of Expression. throughout the code.

ezgif com-resize (3)

@riastrad
Copy link
Contributor Author

Thanks for the review, @langsmith. This is ready for another quick pass as soon as you're ready.

Copy link
Contributor

@langsmith langsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍠

@langsmith
Copy link
Contributor

Looks good!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants