This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Java/Kotlin toggle, MainActivity refactor #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
force-pushed
the
lp-java-kotlin-toggle
branch
from
5eed1be
to
48b2a34
Compare
|
Looks great @LukasPaczos . Thanks for the big lift. I made a commit that adjusts the line length of the
|
|
👍 thanks @langsmith |
langsmith
approved these changes
Oct 9, 2018
langsmith
force-pushed
the
lp-java-kotlin-toggle
branch
from
eb38ec4
to
edc32c7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Java/Kotlinexamples toggle, newKotlinLocationPluginActivity, as well as a refactor of the wholeMainActivityand recycler adapter.I'm open for design suggestions when it comes to the toggle.