Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Remove Transfuser Errata #870

Merged
merged 2 commits into from
Oct 3, 2018
Merged

Remove Transfuser Errata #870

merged 2 commits into from
Oct 3, 2018

Conversation

riastrad
Copy link
Contributor

@riastrad riastrad commented Oct 2, 2018

Per @colleenmcginnis's comment in mapbox/android-docs#639. This PR removes the code comments that were required to use the example-transfuser. Now that the docs are referencing submodules, those comments are no longer necessary and if anything would only be contributing needless noise to our code snippets.

cc: @mapbox/maps-android

Copy link
Member

@zugaldia zugaldia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capturing chat with @riastrad - we no longer need transfuser when we're embedding the whole file with the new submodules approach (which makes it easier to keep the examples in sync). However, we'd still use transfuser for snippets in the docs where only certain parts of the code are required and including the whole file would be too noisy (e.g. location engine functionality, permission utils, plugins...).

@riastrad
Copy link
Contributor Author

riastrad commented Oct 3, 2018

Thanks @zugaldia. Spoke with @colleenmcginnis about this and just want to clarify the following point: currently /android-docs/ does not include any snippets that aren't full java files.

Tutorials and example code snippets on /help still rely on example-transfuser but are not pulled in from this repo. As a result, they are not affected by the transition to submodules.

@riastrad riastrad merged commit 53cf889 into master Oct 3, 2018
@riastrad riastrad deleted the je-nix-transfuser-comments branch October 3, 2018 17:05
@langsmith langsmith mentioned this pull request Nov 1, 2018
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants