-
Notifications
You must be signed in to change notification settings - Fork 493
Transparent background + video example #820
Conversation
8b81f75
to
9c28d4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should stop the video in onDestroy
} | ||
|
||
@Override | ||
protected void onDestroy() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that you start the video onCreate
Should you stop it in onDestroy?
I would be curious to see how it works on a tablet on Orientation change. My tablet is at home in PA though :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@langsmith What happens if you start in landscape? Is it ok then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6cc457d
to
eddb531
Compare
c9f07ec
to
f9c9d6e
Compare
Ok, @osana . I think this is ready for another review. Things are working with |
Resolves #802 . Still need to figure out why the
VideoView
isn't filling the entire screen, despitematch_parent
for width/height in XML 🤔