Transparent background + video example #820
Conversation
langsmith
force-pushed
the
ls-transparent-background
branch
from
8b81f75
to
9c28d4c
Compare
|
Figured it out. The water now takes up the entire screen in the background. The video of moving water in the background, makes it hard to record a GIF to post here. Welcome to switch to this branch and install the app on your phone.
|
| } | ||
|
|
||
| @Override | ||
| protected void onDestroy() { |
There was a problem hiding this comment.
Given that you start the video onCreate
Should you stop it in onDestroy?
I would be curious to see how it works on a tablet on Orientation change. My tablet is at home in PA though :(
There was a problem hiding this comment.
Yea, I should stop it in onDestroy(). Fix made and pushed to this pr.
Still funky when in tablet landscape though 😞
There was a problem hiding this comment.
@langsmith What happens if you start in landscape? Is it ok then?
There was a problem hiding this comment.
Made your suggestions regarding onDestroy()
Creation/destruction seems to be 👌
langsmith
force-pushed
the
ls-transparent-background
branch
from
6cc457d
to
eddb531
Compare
langsmith
force-pushed
the
ls-transparent-background
branch
from
c9f07ec
to
f9c9d6e
Compare
|
Ok, @osana . I think this is ready for another review. Things are working with |
Resolves #802 . Still need to figure out why the
VideoViewisn't filling the entire screen, despitematch_parentfor width/height in XML 🤔