Multiple version bump hotfixes #643

langsmith · 2018-03-05T22:15:06Z

This pr fixes many broken APIs, import lines, and other refactoring that are all related to recent changes in our tools (Mapbox Java, plugins, etc.). For some reason, CircleCI didn't catch this 😟

snijsure · 2018-03-05T23:03:09Z

@langsmith I am trying to run demo app on my pixel and keep getting following exception when running on master branch as well as ls-multiple-version-bump-hotfixes branch

I am at commit 03bef9d485e79195ac7471d9f3c44b7fd50fbf69

I am running command ./gradlew clean installDebug to build & install demo app.

Error I see is this:

03-05 14:59:38.477 26163 26163 E AndroidRuntime: Process: com.mapbox.mapboxandroiddemo, PID: 26163
03-05 14:59:38.477 26163 26163 E AndroidRuntime: java.lang.RuntimeException: Unable to start activity ComponentInfo{com.mapbox.mapboxandroiddemo/com.mapbox.mapboxandroiddemo.MainActivity}: java.lang.IllegalStateException: Could not find wearable shared library classes. Please add <uses-library android:name="com.google.android.wearable" android:required="false" /> to the application manifest
03-05 14:59:38.477 26163 26163 E AndroidRuntime: 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2778)
03-05 14:59:38.477 26163 26163 E AndroidRuntime: 	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2856)
03-05 14:59:38.477 26163 26163 E AndroidRuntime: 	at android.app.ActivityThread.-wrap11(Unknown Source:0)
03-05 14:59:38.477 26163 26163 E AndroidRuntime: 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1589)
03-05 14:59:38.477 26163 26163 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:106)
03-05 14:59:38.477 26163 26163 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:164)
03-05 14:59:38.477 26163 26163 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:6494)
03-05 14:59:38.477 26163 26163 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
03-05 14:59:38.477 26163 26163 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
03-05 14:59:38.477 26163 26163 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)
03-05 14:59:38.477 26163 26163 E AndroidRuntime: Caused by: java.lang.IllegalStateException: Could not find wearable shared library classes. Please add <uses-library android:name="com.google.android.wearable" android:required="false" /> to the application manifest
03-05 14:59:38.477 26163 26163 E AndroidRuntime: 	at android.support.wearable.internal.SharedLibraryVersion.verifySharedLibraryPresent(SharedLibraryVersion.java:39)
03-05 14:59:38.477 26163 26163 E AndroidRuntime: 	at android.support.wearable.activity.WearableActivityDelegate.initAmbientSupport(WearableActivityDelegate.java:137)
03-05 14:59:38.477 26163 26163 E AndroidRuntime: 	at android.support.wearable.activity.WearableActivityDelegate.onCreate(WearableActivityDelegate.java:34)
03-05 14:59:38.477 26163 26163 E AndroidRuntime: 	at android.support.wearable.activity.WearableActivity.onCreate(WearableActivity.java:53)
03-05 14:59:38.477 26163 26163 E AndroidRuntime: 	at com.mapbox.mapboxandroiddemo.MainActivity.onCreate(MainActivity.java:31)
03-05 14:59:38.477 26163 26163 E AndroidRuntime: 	at android.app.Activity.performCreate(Activity.java:6999)
03-05 14:59:38.477 26163 26163 E AndroidRuntime: 	at android.app.Activity.performCreate(Activity.java:6990)
03-05 14:59:38.477 26163 26163 E AndroidRuntime: 	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1214)
03-05 14:59:38.477 26163 26163 E AndroidRuntime: 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2731)
03-05 14:59:38.477 26163 26163 E AndroidRuntime: 	... 9 more
03-05 14:59:38.480   877  2506 W ActivityManager:   Force finishing activity com.mapbox.mapboxandroiddemo/.MainActivity

langsmith · 2018-03-05T23:05:33Z

Thanks @snijsure , putting out multiple 🔥 right now but will definitely look into it and get back to you.

Ticketed here for future work/tracking

This reverts commit d21be91.

cammace · 2018-03-06T14:32:30Z

.gitignore

@@ -11,3 +11,4 @@ build
 gradlew.bat
 *.properties
 src/main/res/
+MapboxAndroidDemo/src/main/java/com/mapbox/mapboxandroiddemo/account/AccountRetrievalService.java


Why is this being added to the gitignore file? Any chance you could add a comment above it explaining what the file is and why it's not being checked in to git?

Removed from gitignore file. Was part of an experiment 🔬

cammace · 2018-03-06T14:34:36Z

...mo/src/main/java/com/mapbox/mapboxandroiddemo/examples/javaservices/MapMatchingActivity.java

@@ -129,7 +132,11 @@ protected void onSaveInstanceState(Bundle outState) {
        inputStream.close();
        FeatureCollection featureCollection = FeatureCollection.fromJson(sb.toString());
        LineString lineString = (LineString) featureCollection.getFeatures().get(0).getGeometry();
-        points = lineString.getCoordinates();
+        for (int x = 0; x < lineString.getCoordinates().size(); x++) {


use foreach here

cammace · 2018-03-06T14:36:00Z

...mo/src/main/java/com/mapbox/mapboxandroiddemo/examples/javaservices/MapMatchingActivity.java

@@ -181,16 +186,16 @@ public void onResponse(Call<MapMatchingResponse> call, Response<MapMatchingRespo
            // Convert the map matched response list from position to latlng coordinates.
            // By default, the SDK uses MapMatchingCriteria.GEOMETRY_POLYLINE_6, therefore
            // you need Constants.PRECISION_6 for the decode to be right
-            String geometry = response.body().getMatchings().get(0).getGeometry();
+            String geometry = response.body().matchings().get(0).geometry();
            List<Position> positions = PolylineUtils.decode(geometry, Constants.PRECISION_6);


This needs to be Point right?

PolylineUtils.decode returns List<Position>

cammace · 2018-03-06T14:36:08Z

...mo/src/main/java/com/mapbox/mapboxandroiddemo/examples/javaservices/MapMatchingActivity.java

@@ -181,16 +186,16 @@ public void onResponse(Call<MapMatchingResponse> call, Response<MapMatchingRespo
            // Convert the map matched response list from position to latlng coordinates.
            // By default, the SDK uses MapMatchingCriteria.GEOMETRY_POLYLINE_6, therefore
            // you need Constants.PRECISION_6 for the decode to be right
-            String geometry = response.body().getMatchings().get(0).getGeometry();
+            String geometry = response.body().matchings().get(0).geometry();
            List<Position> positions = PolylineUtils.decode(geometry, Constants.PRECISION_6);
            if (positions == null) {
              return;
            }

            for (int i = 0; i < positions.size(); i++) {


Convert to foreach?

cammace · 2018-03-06T14:37:25Z

...Demo/src/main/java/com/mapbox/mapboxandroiddemo/examples/javaservices/MatrixApiActivity.java

@@ -174,7 +175,7 @@ public void onFailure(Call<DirectionsMatrixResponse> call, Throwable throwable)
  private void addMarkers() {
    Icon lightningBoltIcon = IconFactory.getInstance(MatrixApiActivity.this)
      .fromResource(R.drawable.lightning_bolt);
-    for (Feature feature : featureCollection.getFeatures()) {
+    for (com.mapbox.geojson.Feature feature : featureCollection.features()) {


Any reason this is using the full namespace here?

Fixed. Full namespace removed

cammace · 2018-03-06T14:38:52Z

...Demo/src/main/java/com/mapbox/mapboxandroiddemo/examples/javaservices/MatrixApiActivity.java

-      positionList.add(singleLocationPosition);
+    for (Feature singleLocation : featureCollection.features()) {
+      Point singleLocationPoint = (Point) singleLocation.geometry();
+      pointList.add(singleLocationPoint);


You should add the item directly to the list rather than declaring a local variable and then passing it in.

cammace · 2018-03-06T14:39:23Z

...Demo/src/main/java/com/mapbox/mapboxandroiddemo/examples/javaservices/MatrixApiActivity.java

    }
  }

  private void initMatrixLocationListForRecyclerView() {
    matrixLocationList = new ArrayList<>();
-    for (int x = 0; x < featureCollection.getFeatures().size(); x++) {
+    for (int x = 0; x < featureCollection.features().size(); x++) {


cammace · 2018-03-06T14:40:09Z

...o/src/main/java/com/mapbox/mapboxandroiddemo/examples/javaservices/OptimizationActivity.java

+      .overview(DirectionsCriteria.OVERVIEW_FULL)
+      .profile(DirectionsCriteria.PROFILE_DRIVING)
+      .accessToken(Mapbox.getAccessToken())
+


remove extra space?

cammace · 2018-03-06T14:42:52Z

MapboxAndroidDemo/src/main/java/com/mapbox/mapboxandroiddemo/labs/IndoorMapActivity.java

+        mapboxMap.addOnCameraMoveListener(new MapboxMap.OnCameraMoveListener() {
+          @Override
+          public void onCameraMove() {
+            if (mapboxMap.getCameraPosition().zoom > 16) {
              try {


This turf exception can be removed, it's now runtime

cammace · 2018-03-06T14:42:59Z

MapboxAndroidDemo/src/main/java/com/mapbox/mapboxandroiddemo/labs/IndoorMapActivity.java

@@ -97,6 +101,7 @@ public void onCameraChange(CameraPosition position) {
              hideLevelButton();
            }
          }
+


Langston Smith added 8 commits March 2, 2018 16:52

initial broken api fixes

daee995

more refactoring

d21be91

more refactoring

b65441d

more import line refactoring

e9b5c79

more api fixes

ff51990

more refactoring of DirectionsMatrixApiActivity

815f39b

Refactored name of DirectionsMatrixApiActivity

d8349f8

more refactoring

7264b9f

langsmith added bug 🐛 work in progress 🏗️ crash 💥 labels Mar 5, 2018

langsmith self-assigned this Mar 5, 2018

Langston Smith added 11 commits March 5, 2018 15:14

Merge branch 'master' into ls-multiple-version-bump-hotfixes

f7fefd3

Revert "flow secret"

88095d7

This reverts commit d21be91.

added retrieval service to ignore file

8afa376

fixed location engine in location plugin activity

68e6a66

fixed matrix api activity

4581585

comment change

5c9d462

Fixed location picker activity

f13a1df

adjusted map style for places plugin

b18790d

Revert clientse

21113aa

comment update

1832d51

removed outdated duplicated matrix api examle

42c6a14

langsmith requested review from cammace and osana March 6, 2018 14:21

langsmith added ✓ ready for review 👍 and removed work in progress 🏗️ labels Mar 6, 2018

cammace suggested changes Mar 6, 2018

View reviewed changes

Langston Smith added 3 commits March 6, 2018 07:16

changes based on cam's review

e8cf9fa

checkstyle: removed unused import line

17e7784

removed line from git ignore

e5829c3

langsmith mentioned this pull request Mar 6, 2018

Wearable IllegalStateException #645

Closed

Final tweaks

cf3e462

tobrun mentioned this pull request Mar 6, 2018

rename resource to mapbox_auth_flow_secret #646

Merged

rename resource to mapbox_auth_flow_secret (#646)

951cbb3

langsmith mentioned this pull request Mar 6, 2018

Example Crashing #641

Closed

cammace approved these changes Mar 6, 2018

View reviewed changes

langsmith merged commit 0a39320 into master Mar 6, 2018

langsmith deleted the ls-multiple-version-bump-hotfixes branch March 6, 2018 23:03

langsmith mentioned this pull request Mar 9, 2018

Matrix API example crash #649

Closed

langsmith mentioned this pull request Feb 7, 2019

Added wearable declaration tag to manifest #963

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multiple version bump hotfixes #643

Multiple version bump hotfixes #643

langsmith commented Mar 5, 2018

snijsure commented Mar 5, 2018 •

edited

Loading

langsmith commented Mar 5, 2018 •

edited

Loading

cammace Mar 6, 2018

langsmith Mar 6, 2018

cammace Mar 6, 2018

langsmith Mar 6, 2018

cammace Mar 6, 2018

langsmith Mar 6, 2018

cammace Mar 6, 2018

langsmith Mar 6, 2018

cammace Mar 6, 2018

langsmith Mar 6, 2018

cammace Mar 6, 2018

langsmith Mar 6, 2018

cammace Mar 6, 2018

langsmith Mar 6, 2018

cammace Mar 6, 2018

langsmith Mar 6, 2018

cammace Mar 6, 2018

langsmith Mar 6, 2018

cammace Mar 6, 2018

langsmith Mar 6, 2018

Multiple version bump hotfixes #643

Multiple version bump hotfixes #643

Conversation

langsmith commented Mar 5, 2018

snijsure commented Mar 5, 2018 • edited Loading

langsmith commented Mar 5, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

snijsure commented Mar 5, 2018 •

edited

Loading

langsmith commented Mar 5, 2018 •

edited

Loading