Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Multiple geometries example #490

Merged
merged 21 commits into from
Oct 4, 2017

Conversation

langsmith
Copy link
Contributor

Resolves #417 by adding an example of drawing multiple GeoJSON geometries (polygon, line, etc) that are in a single GeoJSON file.

@langsmith langsmith self-assigned this Sep 29, 2017
@langsmith
Copy link
Contributor Author

Ok, this is ready to go @zugaldia . Couldn't remove the random commits that add spacing to the Fenway geoJSON (actually a file that's not needed anymore [will remove in a new branch/pr]) and to the single line in the LA Tourism activity.

ezgif com-resize 1

Copy link
Member

@zugaldia zugaldia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small changes.

mapView.onSaveInstanceState(outState);
}

private String loadJsonFromAsset(String filename) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@langsmith Isn't this something that you now could do with the new GeoJSON plugin? If so, let's use it instead! :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed off of Github, the plugin doesn't allow the fine grain styling control that's needed for this particular demo app example. GeoJSON plugin doesn't allow styling of Point geometries.

ticketed here


private MapView mapView;
private MapboxMap mapboxMap;
private static final String GEOJSON_SOURCE_ID = "GEOJSON FILE";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though maybe not an API requirement, I prefer not including spaces in ID names.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@zugaldia
Copy link
Member

zugaldia commented Oct 4, 2017

Couldn't remove the random commits that add spacing to the Fenway geoJSON

You can probably download the original from master and just overwrite + recommit the one in this branch.

@langsmith
Copy link
Contributor Author

Requests have been made. Good to go @zugaldia

@langsmith langsmith merged commit eca8f75 into master Oct 4, 2017
@langsmith langsmith deleted the ls-multiple-geometries-example-with-dds branch October 4, 2017 20:00
@vuhiepth7
Copy link

vuhiepth7 commented Feb 15, 2020

I run example of Draw Multiple geometries but it hasn't
changes. I added access token and use your demo. Please!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add multiple geometries from one GeoJSON source example
3 participants