-
Notifications
You must be signed in to change notification settings - Fork 493
Conversation
…hub.com/mapbox/mapbox-android-demo into ls-multiple-geometries-example-with-dds
Ok, this is ready to go @zugaldia . Couldn't remove the random commits that add spacing to the Fenway geoJSON (actually a file that's not needed anymore [will remove in a new branch/pr]) and to the single line in the LA Tourism activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small changes.
mapView.onSaveInstanceState(outState); | ||
} | ||
|
||
private String loadJsonFromAsset(String filename) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@langsmith Isn't this something that you now could do with the new GeoJSON plugin? If so, let's use it instead! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed off of Github, the plugin doesn't allow the fine grain styling control that's needed for this particular demo app example. GeoJSON plugin doesn't allow styling of Point
geometries.
|
||
private MapView mapView; | ||
private MapboxMap mapboxMap; | ||
private static final String GEOJSON_SOURCE_ID = "GEOJSON FILE"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though maybe not an API requirement, I prefer not including spaces in ID names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
You can probably download the original from |
Requests have been made. Good to go @zugaldia |
I run example of Draw Multiple geometries but it hasn't |
Resolves #417 by adding an example of drawing multiple GeoJSON geometries (polygon, line, etc) that are in a single GeoJSON file.