This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Use default marker icon #1353
Merged
Use default marker icon #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colleenmcginnis
commented
May 28, 2020
...emo/src/main/java/com/mapbox/mapboxandroiddemo/examples/styles/BasicSymbolLayerActivity.java
Outdated
Show resolved
Hide resolved
added 2 commits
May 28, 2020 12:58
langsmith
approved these changes
May 28, 2020
There was a problem hiding this comment.
Looks good! Thanks @colleenmcginnis . Markers are flickering when they collide, but that's because of:
/mapbox/mapbox-gl-native/issues/16471, /mapbox/mapbox-gl-native/issues/16473, mapbox/mapbox-gl-native-android#392 (comment), etc. Fix has been created and will land in Maps SDK in an upcoming releases
🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the default red marker icon (
mapbox_marker_icon_default) in theBasicSymbolLayerActivity.javato reduce friction for users who just want to add a marker to a map. 🎸 There's already an offset built intomapbox_marker_icon_default, soiconOffset(new Float[] {0f, -9f})is no longer needed.@langsmith is this all that needs to be done?