This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Refactoring RelativeLayout to FrameLayout #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
reviewed
Sep 2, 2019
MapboxAndroidDemo/src/china/res/layout/activity_style_color_switcher.xml
Outdated
Show resolved
Hide resolved
langsmith
force-pushed
the
ls-removing-unneeded-relativelayout
branch
from
c59499d
to
0c2f16a
Compare
LukasPaczos
approved these changes
Sep 3, 2019
langsmith
force-pushed
the
ls-removing-unneeded-relativelayout
branch
from
1cddc9e
to
a70d9ee
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr refactors many XML layouts because they were unnecessarily using
RelativeLayoutwhenFrameLayoutwould suffice. China flavor layouts are also adjusted in this pr (cc @Chaoba )