Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Add example of multiple geometries based on Directions route #1158

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

langsmith
Copy link
Contributor

@langsmith langsmith commented Aug 2, 2019

Resolves #1055 by adding an example of showing different geometries based on a single Mapbox Directions API response.

ezgif com-resize (8)

@langsmith
Copy link
Contributor Author

Work in progress because I'm still trying to figure out why there's weird CircleLayer flashing happening between a certain zoom level range.

ezgif com-resize (7)

@langsmith langsmith force-pushed the ls-multiple-directions-route-geometries branch 2 times, most recently from aa39dca to 07d1326 Compare August 2, 2019 23:06
@langsmith langsmith force-pushed the ls-multiple-directions-route-geometries branch from 07d1326 to 8b138cf Compare August 19, 2019 23:10
@langsmith
Copy link
Contributor Author

Ok, I think this is ready for some review. No rush. Rather than messing around with layer filters and a GeometryCollection, I just switched to using two different GeoJsonSources

ezgif com-resize (8)

@langsmith
Copy link
Contributor Author

Ok @tobrun . Changes made based on your review.

@langsmith langsmith force-pushed the ls-multiple-directions-route-geometries branch from 79a6bd0 to bda71af Compare August 20, 2019 23:56
@langsmith langsmith force-pushed the ls-multiple-directions-route-geometries branch from bda71af to c5e7331 Compare September 3, 2019 18:53
@langsmith
Copy link
Contributor Author

Anything else, @tobrun ?

@langsmith langsmith force-pushed the ls-multiple-directions-route-geometries branch from c5e7331 to fe37d76 Compare September 6, 2019 17:57
@langsmith langsmith force-pushed the ls-multiple-directions-route-geometries branch from 25c54e6 to 39fb9d6 Compare September 10, 2019 14:04
@langsmith langsmith merged commit b090a43 into master Sep 10, 2019
@langsmith langsmith deleted the ls-multiple-directions-route-geometries branch September 10, 2019 14:16
@langsmith langsmith mentioned this pull request Sep 17, 2019
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example of multiple geometries based on Directions route
4 participants