This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Adding example of "revealed" polygon hole with outline #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example like this could be used to create something like @ClareTrainor 's map 👇 😃
|
langsmith
force-pushed
the
ls-shaded-polygon-hole-with-outline-example
branch
2 times, most recently
from
031016c
to
9ce9bbd
Compare
tobrun
requested review from
LukasPaczos and
tobrun
and removed request for
osana
LukasPaczos
reviewed
May 23, 2019
.../main/java/com/mapbox/mapboxandroiddemo/examples/dds/RevealedPolygonHoleOutlineActivity.java
Outdated
Show resolved
Hide resolved
.../main/java/com/mapbox/mapboxandroiddemo/examples/dds/RevealedPolygonHoleOutlineActivity.java
Outdated
Show resolved
Hide resolved
.../main/java/com/mapbox/mapboxandroiddemo/examples/dds/RevealedPolygonHoleOutlineActivity.java
Outdated
Show resolved
Hide resolved
langsmith
force-pushed
the
ls-shaded-polygon-hole-with-outline-example
branch
from
9ce9bbd
to
c4100ef
Compare
langsmith
force-pushed
the
ls-shaded-polygon-hole-with-outline-example
branch
from
c4100ef
to
84504b9
Compare
|
All feedback addressed, @LukasPaczos . Anything else? |
I also added camera bounds.
|
|
jl.joker
…On May 24, 2019 16:27, "Łukasz Paczos" ***@***.***> wrote:
***@***.**** approved this pull request.
🚢
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1050?email_source=notifications&email_token=AJBSVGB6O2VJAST6G5LLBWTPW6RHFA5CNFSM4HLNJS5KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZTLN3Y#pullrequestreview-241612527>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJBSVGAMYA2J5ES4SXBZXOTPW6RHFANCNFSM4HLNJS5A>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds an example of an outlined polygon hole in a larger shaded area in San José (cc @1ec5). Inspired by
