This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Define a Circle's Radius with Physical Units #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@riastrad , you see yourself being able to work on this in the near(ish) future? Or should I take over on this pr? |
|
@langsmith I don't foresee being able to pick this up within the next couple of weeks 😬 |
|
Ok, no problem |
langsmith
force-pushed
the
je-physical-units
branch
from
35be7f5
to
a1306fb
Compare
langsmith
force-pushed
the
je-physical-units
branch
from
a1306fb
to
1590c03
Compare
langsmith
force-pushed
the
je-physical-units
branch
2 times, most recently
from
259e37a
to
cb966a8
Compare
langsmith
force-pushed
the
je-physical-units
branch
from
cb966a8
to
acd7cf1
Compare
|
Ok, this is ready for some review.
|
LukasPaczos
approved these changes
Jul 23, 2019
| circleStepsSeekbar.setOnSeekBarChangeListener(new SeekBar.OnSeekBarChangeListener() { | ||
| @Override | ||
| public void onProgressChanged(SeekBar seekBar, int progress, boolean fromUser) { | ||
| if (progress < MINIMUM_CIRCLE_STEPS) { |
There was a problem hiding this comment.
NIT: I believe that this constraint can be enforced by simply adding an XML property/calling a settter.
| // Empty on purpose. Not used in this example. | ||
| } | ||
|
|
||
| private void adjustTextView(int string, TextView textView, int progress, int difference) { |
There was a problem hiding this comment.
difference seems unnecessary here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1032
This PR demonstrates how to add a circle to the map with a radius specified in various physical units. It leverages
TurfTransformation#circle()so it is being added under the "Java Services" section of the app.cc: @langsmith