This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Add symbol listener activity #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langsmith
reviewed
Mar 27, 2019
| mapView = findViewById(R.id.mapView); | ||
| mapView.onCreate(savedInstanceState); | ||
| mapView.getMapAsync(this); | ||
|
|
There was a problem hiding this comment.
nit: delete this blank line 😬
langsmith
reviewed
Mar 27, 2019
...Demo/src/main/java/com/mapbox/mapboxandroiddemo/examples/plugins/SymbolListenerActivity.java
Show resolved
Hide resolved
langsmith
reviewed
Mar 27, 2019
...Demo/src/main/java/com/mapbox/mapboxandroiddemo/examples/plugins/SymbolListenerActivity.java
Show resolved
Hide resolved
langsmith
reviewed
Mar 27, 2019
...Demo/src/main/java/com/mapbox/mapboxandroiddemo/examples/plugins/SymbolListenerActivity.java
Show resolved
Hide resolved
langsmith
reviewed
Mar 27, 2019
| @@ -81,6 +81,7 @@ | |||
| <string name="activity_plugins_building_plugin_description">Use the building plugin to easily display 3D building height</string> | |||
| <string name="activity_plugins_geojson_plugin_description">Easily retrieve GeoJSON data from a url, asset, or path</string> | |||
| <string name="activity_plugins_places_plugin_description">Add location search ("geocoding") functionality and UI to search for any place in the world</string> | |||
| <string name="activity_plugins_symbol_listener_description">Listen for Symbol interaction using the Annotations plugin and built-in listeners</string> | |||
There was a problem hiding this comment.
Suggested change
| <string name="activity_plugins_symbol_listener_description">Listen for Symbol interaction using the Annotations plugin and built-in listeners</string> | |
| <string name="activity_plugins_symbol_listener_description">Listen for Symbol interaction using the Annotation plugin and its built-in listeners</string> |
langsmith
reviewed
Mar 27, 2019
| @@ -10,6 +10,11 @@ android { | |||
| compileSdkVersion androidVersions.compileSdkVersion | |||
| buildToolsVersion androidVersions.buildToolsVersion | |||
|
|
|||
| compileOptions { | |||
There was a problem hiding this comment.
I don't think you need this compileOptionssection anymore. I tried removing it and the example works just fine for me.
langsmith
reviewed
Mar 27, 2019
| private static final String MAKI_ICON_AIRPORT = "airport-15"; | ||
| private SymbolManager symbolManager; | ||
| private Symbol symbol; | ||
| private final List<ValueAnimator> animators = new ArrayList<>(); |
There was a problem hiding this comment.
You can delete this. You're not using it anywhere in the example.
langsmith
reviewed
Mar 27, 2019
| OnMapReadyCallback { | ||
|
|
||
| private MapView mapView; | ||
| private MapboxMap mapboxMap; |
There was a problem hiding this comment.
You can delete this. Field can be converted to a local variable (on line 62).
langsmith
reviewed
Mar 27, 2019
| @Override | ||
| public void onMapReady(@NonNull final MapboxMap mapboxMap) { | ||
|
|
||
| this.mapboxMap = mapboxMap; |
There was a problem hiding this comment.
You can delete this. You don't use mapboxMap elsewhere.
added 2 commits
March 27, 2019 16:23
…mapbox-android-demo into sf-final-symbol-listener-example
|
Thanks @langsmith! Let me know what you think now. |
|
@langsmith It looks like Circle is failing and I think it's due to the compileOptions code that was removed here: #1000 (review) |
|
Ok, then let's add that |
added 2 commits
March 27, 2019 17:11
…mapbox-android-demo into sf-final-symbol-listener-example
|
@langsmith Passing now. OK to merge? |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #995
Langston edit: added the GIF
