-
Notifications
You must be signed in to change notification settings - Fork 493
Conversation
mapView = findViewById(R.id.mapView); | ||
mapView.onCreate(savedInstanceState); | ||
mapView.getMapAsync(this); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: delete this blank line 😬
...Demo/src/main/java/com/mapbox/mapboxandroiddemo/examples/plugins/SymbolListenerActivity.java
Show resolved
Hide resolved
...Demo/src/main/java/com/mapbox/mapboxandroiddemo/examples/plugins/SymbolListenerActivity.java
Show resolved
Hide resolved
...Demo/src/main/java/com/mapbox/mapboxandroiddemo/examples/plugins/SymbolListenerActivity.java
Show resolved
Hide resolved
@@ -81,6 +81,7 @@ | |||
<string name="activity_plugins_building_plugin_description">Use the building plugin to easily display 3D building height</string> | |||
<string name="activity_plugins_geojson_plugin_description">Easily retrieve GeoJSON data from a url, asset, or path</string> | |||
<string name="activity_plugins_places_plugin_description">Add location search ("geocoding") functionality and UI to search for any place in the world</string> | |||
<string name="activity_plugins_symbol_listener_description">Listen for Symbol interaction using the Annotations plugin and built-in listeners</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<string name="activity_plugins_symbol_listener_description">Listen for Symbol interaction using the Annotations plugin and built-in listeners</string> | |
<string name="activity_plugins_symbol_listener_description">Listen for Symbol interaction using the Annotation plugin and its built-in listeners</string> |
@@ -10,6 +10,11 @@ android { | |||
compileSdkVersion androidVersions.compileSdkVersion | |||
buildToolsVersion androidVersions.buildToolsVersion | |||
|
|||
compileOptions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need this compileOptions
section anymore. I tried removing it and the example works just fine for me.
private static final String MAKI_ICON_AIRPORT = "airport-15"; | ||
private SymbolManager symbolManager; | ||
private Symbol symbol; | ||
private final List<ValueAnimator> animators = new ArrayList<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can delete this. You're not using it anywhere in the example.
OnMapReadyCallback { | ||
|
||
private MapView mapView; | ||
private MapboxMap mapboxMap; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can delete this. Field can be converted to a local variable (on line 62).
@Override | ||
public void onMapReady(@NonNull final MapboxMap mapboxMap) { | ||
|
||
this.mapboxMap = mapboxMap; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can delete this. You don't use mapboxMap
elsewhere.
…mapbox-android-demo into sf-final-symbol-listener-example
Thanks @langsmith! Let me know what you think now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🙇
@langsmith It looks like Circle is failing and I think it's due to the compileOptions code that was removed here: #1000 (review) |
Ok, then let's add that |
…mapbox-android-demo into sf-final-symbol-listener-example
@langsmith Passing now. OK to merge? |
Resolves #995
Langston edit: added the GIF