Refactor test fixtures #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will help quite a bit keeping the fixtures in sync, I like it! |
mourner
added a commit
that referenced
this pull request
Aug 19, 2019
* master: (32 commits) fix incorrect equality case in intersection test (#114) refactor test fixtures (#113) fix test for #111 update readme for 2.1.5 2.1.5 fix a race condition with coincident chain of holes (#112) upgrade deps update readme 2.1.4 fix a race condition that could lead to a hang Reuse fixture files in benchmarks (#100) Replace vertice with vertex in documentation (#97) upgrade deps, update scripts 2.1.3 Search with equal priority in both z-order directions update changelog 2.1.2 fix a few race conditions (port from C++) (#90) Support export default (#88) upgrade deps ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expected.jsonfile.0and added non-0 deviations explicitly so that there's a clear list of tests that aren't expected to triangulate perfectly.This will potentially allow us to keep the tests between earcut and earcut-cpp in sync easier. cc @mrgreywater