Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor contrast with scm state in file explorer #1

Open
connor4312 opened this issue Jul 7, 2021 · 7 comments
Open

Poor contrast with scm state in file explorer #1

connor4312 opened this issue Jul 7, 2021 · 7 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@connor4312
Copy link

VS Code highlights files with different colors when they're ignored, modified, added, or removed in scm/git. These colors could use a little tweaking:

@manekinekko
Copy link
Owner

Thank @connor4312 for filling this issue.

I did few tests. Would the following color palette work?

image

@manekinekko manekinekko self-assigned this Jul 7, 2021
@manekinekko manekinekko added the bug Something isn't working label Jul 7, 2021
@connor4312
Copy link
Author

Looks great! I would still prefer something else for the "ignored" folder though, reading it is painful. Maybe the same or a slightly darker grey than the activity bar icons?

@manekinekko
Copy link
Owner

What about this palette?

image

@miguelsolorio
Copy link

Is there a reason why icon.foreground was set to white? Those seem to stand out as low contrast after these changes. You can also set the icon colors when an item is selected via list.activeSelectionIconForeground

@manekinekko
Copy link
Owner

The problem is when hovering over a list of items, the icons in black are not readable at all.

image

The list.activeSelectionIconForeground options only set the icon color when the selection is active:

image

@manekinekko manekinekko reopened this Jul 8, 2021
@leninnava
Copy link

leninnava commented Jan 16, 2024

@manekinekko Adding to this, this is how it looks on Windows
image

Typography seems to be thinner on Windows and the pink / magenta for untracked files is a bit hard to read. Will make sure it's not related to any setting I have and will try to fix this myself when I have the chance!

@manekinekko
Copy link
Owner

Thanks for the update @leninnava. Happy to review any PR you will submit.

@manekinekko manekinekko added help wanted Extra attention is needed good first issue Good for newcomers labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants