Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.3.2 contains a breaking change #6

Closed
alexcrichton opened this issue Dec 20, 2018 · 6 comments
Closed

0.3.2 contains a breaking change #6

alexcrichton opened this issue Dec 20, 2018 · 6 comments
Labels

Comments

@alexcrichton
Copy link

We're seeing breakage on Rust's CI for a breaking change in the 0.3.2 release:

[00:03:50] error[E0308]: mismatched types
[00:03:50]  --> /cargo/registry/src/github.com-1ecc6299db9ec823/cargo-0.32.0/src/cargo/util/sha256.rs:9:34
[00:03:50]   |
[00:03:50] 9 |         let hasher = Hasher::new(Algorithm::SHA256);
[00:03:50]   |                                  ^^^^^^^^^^^^^^^^^
[00:03:50]   |                                  |
[00:03:50]   |                                  expected reference, found enum `util::sha256::crypto_hash::Algorithm`
[00:03:50]   |                                  help: consider borrowing here: `&Algorithm::SHA256`
[00:03:50]   |
[00:03:50]   = note: expected type `&util::sha256::crypto_hash::Algorithm`
[00:03:50]              found type `util::sha256::crypto_hash::Algorithm`
[00:03:50] 
[00:03:50] error: aborting due to previous error
[00:03:50] 
[00:03:50] For more information about this error, try `rustc --explain E0308`.

It looks like a reference wasn't previously needed but now it is? Would it be possible to yank 0.3.2 and publish 0.3.3 with a fix?

@malept
Copy link
Owner

malept commented Dec 20, 2018

Ah, crap. I forgot about

pub use imp::Hasher;

Let me see if I can do this quickly. It may not happen until after 6pm PT.

@alexcrichton
Copy link
Author

Ok thanks! If possible, mind doing a quick yank for us?

@alexcrichton
Copy link
Author

Ah I see it's in there now, thanks!

@malept
Copy link
Owner

malept commented Dec 20, 2018

It's been yanked. I'll release a 0.3.3 shortly.

@malept
Copy link
Owner

malept commented Dec 20, 2018

0.3.3 has been released, without the API change.

@malept malept closed this as completed Dec 20, 2018
@alexcrichton
Copy link
Author

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants