-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It is not possible to receive sound end callback when sound is stopped with a fade. #719
Comments
I guess that it is because the sound is stopped before reaching its end. Would it be possible to have a callback when sound is being stopped? |
I didn't think a stop callback would be needed because since you just passed the details into the |
Practically it would be quite complicated to deal with the time used in Maybe I should explain, why I wanted it. I am working on an integration of your lib to Rebol (scripting language). So far the sound is initialised in a memory, which is managed by Rebol. Rebol is using GC. When the sound handle is not referenced, it may be released. On release I call Its is ok, when used in (Rebol) code like this, because there is the song: play/stream %my-song.mp3 But when user would use just: play/stream %my-song.mp3 there is no reference to the sound and when GC would be evaluated, the sound would be uninitialised and so not audible anymore. Trying to resolve this situation, I lock the Rebol sound handle when the sound is started (so it would not be GCed) and unlock when it is stopped. It is working except the case when the sound is stopped with the tween. It could be simulated in Rebol in code like: stop/fade play/stream %my-song.mp3 0:0:10 ;; the song is faded out in 10s In such a case the end callback is not fired and the handle is locked even when the song is not used and referenced anymore. I am aware that it is an edge case, but it is possible. |
I'm not necessarily against this or anything. But there's a problem - I've changed the API for sound notification stuff in the dev-0.12 branch and I don't want to be adding this to 0.11.x only to break the API when I get 0.12 out. So if I do this, it won't be in before I release 0.12 which might be a ways away (no time frame). I'll leave this open and mark it as a feature request. |
I think it is ok.. when playing a little bit more with your library, I think that having the stop callback would not be enough anyway... I must do a little bit more advanced memory management to deal with miniaudio resources... for example I must have some connection between |
It looks that
ma_sound_end_proc
callback is not fired when sound it stopped with a fade usingma_sound_stop_with_fade_in_pcm_frames
The text was updated successfully, but these errors were encountered: