Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stringify and stringify_pretty consume a JsonValue #198

Open
bsdinis opened this issue Feb 27, 2021 · 1 comment
Open

stringify and stringify_pretty consume a JsonValue #198

bsdinis opened this issue Feb 27, 2021 · 1 comment

Comments

@bsdinis
Copy link

bsdinis commented Feb 27, 2021

I see no reason why they cannot take an immutable reference to a JsonValue.

This would probably save a lot of cloneing.

@bsdinis bsdinis changed the title stringify and stringify_preety consume a JsonValue stringify and stringify_pretty consume a JsonValue Feb 27, 2021
@jurosic
Copy link

jurosic commented Mar 27, 2023

I noticed this too, i looked into the code and it seems it actually just calls the .pretty() method on the JsonValue object, so instad of using stringify_pretty you can use .pretty()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants