Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Improper handling of date strings on event pages #607

Open
liashahnazaryan opened this issue Apr 3, 2024 · 2 comments
Open

Bug: Improper handling of date strings on event pages #607

liashahnazaryan opened this issue Apr 3, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@liashahnazaryan
Copy link
Contributor

Description: The dates displayed in the Important Dates section on the website's event pages do not consistently match what's specified in the wmt_events.json, events.json, and the event's .md files. When there is only general text in the date box, such as "To be announced (follows EMNLP)," it appears fine. However, when a date is accompanied by additional text, only the date itself is displayed.

Steps to reproduce the behavior:

  1. Go to https://machinetranslate.org/wmt24 or https://machinetranslate.org/eamt-2024
  2. Scroll down to the Important Dates section
  3. Compare the displayed dates with the corresponding dates in the wmt_events.json, events.json, wmt24.md, and eamt-2024.md files

Expected behavior: The dates displayed on the event pages should match what's specified in the corresponding data files, including any additional text accompanying the date.

Screenshots [optional]:

Screenshot 2024-04-03 at 17 10 55 Screenshot 2024-04-03 at 17 12 30 Screenshot 2024-04-03 at 17 11 40 Screenshot 2024-04-03 at 17 14 52
@liashahnazaryan liashahnazaryan added the bug Something isn't working label Apr 3, 2024
@tovmasharrison
Copy link
Contributor

I have fixed the bug regarding the WMT events date and will push it soon. However, all date entries should be given in machine-readable format (YYYY-MM-DD). Hence, we came to the conclusion not to give date ranges and only specify the start dates.

I think if there isn't a fixed date we can either skip it or give the median, and if it's unknown, then skipping it should be the option.

What do you think @bittlingmayer ?

(cc) @cefoo

@tovmasharrison
Copy link
Contributor

I have fixed the bug related to the WMT event date generation in #608.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants