Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new unit test for type checking logic #590

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

markdouthwaite
Copy link

@markdouthwaite markdouthwaite commented Feb 8, 2021

Hey again!

In response @maciejkula's request on #588 I've added a test to check all combinations of valid input types for user_ids and item_ids (i.e. tuple, list, ndarray) pass successfully.

To do this, I've added a conftest.py file that includes some handy fixtures for the new test_predict_user_item_inputs_with_valid_types test.

As an aside, I think some of these fixtures might be useful in other tests (not addressed in this PR) too. I'd be happy to look into how existing tests could be streamlined if that would be useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants