Return the loss value after each training round #275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can update the c files if this is interesting to you. |
maciejkula
requested changes
Mar 16, 2018
There was a problem hiding this comment.
Currently you are getting the loss of the last processed example, which is not really what you want.
This is a little bit more complicated. Firstly, you'll need to accumulate the loss. Secondly, in parallel mode the fitting loops are executed in parallel. You will therefore need to accumulate losses separately in each thread and sum on loop completion.
Is that something you'd like to tackle? I am pretty sure this is not worth the effort.
| @@ -780,6 +780,8 @@ def fit_logistic(CSRMatrix item_features, | |||
| item_alpha, | |||
| user_alpha) | |||
|
|
|||
| return loss | |||
There was a problem hiding this comment.
This is, in fact, the loss of the current example. So not what you want at all!
|
Haha, that's my misunderstanding! Let's kill this PR with fire then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Me and @corvuscrypto implemented a way to store the loss value in the model.
Is this interesting to you?
cheers