Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonizes naming pattern of pre-built binaries and unlocks latest permalink #1464

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

axel-kah
Copy link

@axel-kah axel-kah commented Jul 6, 2024

This closes #1463

removes tag names to unlock latest-permalink
changes macos and windows release assets to follow linux naming scheme: lychee-{cpu}-{platform}.{ext}
@mre
Copy link
Member

mre commented Jul 7, 2024

Interesting.

We probably also need to update the Docker images here and here as well as create a PR for the lychee-action here.

The Dockerfiles can be updated in the same PR.

@axel-kah
Copy link
Author

axel-kah commented Jul 7, 2024

@axel-kah
Copy link
Author

axel-kah commented Jul 7, 2024

The test fails seem to be unrelated to my changes. Their implementation contains remarks about flakyness. Maybe increasing the number of re-tries or adding a delay in between would help to reduce the ci-noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: inconsistent naming of gh release assets
2 participants