fix build failure on gcc-14 #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc-14 treats implicitly casting all pointer types to all other pointer types as error now. https://gcc.gnu.org/gcc-14/porting_to.html#warnings-as-errors
thesamesam
reviewed
Jul 28, 2024
plugins/tray.c
Outdated
| @@ -631,7 +631,7 @@ static GtkWidget *tray_constructor(LXPanel *panel, config_setting_t *settings) | |||
| /* Add GDK event filter. */ | |||
| gdk_window_add_filter(NULL, (GdkFilterFunc) tray_event_filter, tr); | |||
| /* Reference the window since it is never added to a container. */ | |||
| tr->invisible = g_object_ref_sink(G_OBJECT(invisible)); | |||
| tr->invisible = (GtkWidget *) g_object_ref_sink(G_OBJECT(invisible)); | |||
There was a problem hiding this comment.
I'm not sure, so forgive me if I'm wrong, but should it be GTK_WIDGET(...) instead to be more idiomatic?
There was a problem hiding this comment.
Thanks! I tested the build with GTK_WIDGET(...) and I have updated the PR.
gcc-14 treats implicitly casting all pointer types to all other pointer types as error now. https://gcc.gnu.org/gcc-14/porting_to.html#warnings-as-errors
|
Applied (with slightly revised commit message). Thank you very much for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcc-14 treats implicitly casting all pointer types to all other pointer types as error now.
https://gcc.gnu.org/gcc-14/porting_to.html#warnings-as-errors