Improve address management

[faboweb]

Is your feature request related to a problem? Please describe.

Currently, it is not possible to have 2 accounts for one network
Currently, we have several separate lists of addresses (local, extension) this is confusing

Describe the solution you'd like

part 1

• add extension accounts to address list
• add local accounts to address list
• reduce card sign in: remove sign in with account, remove sign in with extension
• (optional) on extension accounts update, update also Lunie

part 2

• add more context (stash, controller)
• use names in the user menu
• add max height and scroll bar to user menu address list

part 3

• add button for forgetting an address
• add security warning popup with pw confirmation if trying to forget a local account
• add explanation popup for forgetting an extension account

Describe alternatives you've considered

Additional context

[Bitcoinera]

remove sign in with extension

👀

[faboweb]

Remove the sign in with extension and local sign in options from the card sign in. They are not needed anymore when all addresses appear in the user menu.

[jbibla]

remove sign in with extension

he just means the option on the card sign in modal - because the list should auto-magically appear in the user menu

[Bitcoinera]

ah ok, now I'm getting this task. Cool

[jbibla]

• add more context (stash, controller)
• use names in the user menu
• add max height and scroll bar to user menu address list

[Bitcoinera]

use names in the user menu

But this would be a PR in itself no? The ability to allow people to tag their addresses with names. We'd need a edit function. Should it be a modal opening for editing or how it should look like?

[faboweb]

We would use the names from the extension and the local accounts. For Ledger it would say "Ledger" for explore mode it would say "Explore"

[Bitcoinera]

We would use the names from the extension and the local accounts. For Ledger it would say "Ledger" for explore mode it would say "Explore"

OK, I am happy to work on this. Next thing I am doing after applying reviews to #4607

[Bitcoinera]

So how should I represent the account type (local, ledger, extension) ?

[Bitcoinera]

• add more context (stash, controller)
• use names in the user menu
• add max height and scroll bar to user menu address list

Just accounted for all these things. But we should also merge luniehq/cosmos-keys#103 to be able to display the addressRole for all Polkadot accounts, not only the current one

[Bitcoinera]

I'd have this one left, which is quite cool: (optional) on extension accounts update, update also Lunie

EDIT: done

[Bitcoinera]

To make the addresses computed for UserMenu reactive I just had to add a cache: false directive, as explained here: vuejs/vue#214 (comment) and here vuejs/vue#214 (comment)

[Bitcoinera]

@jbibla I can help you with this one, adding the logic: "add button for forgetting an address"

[jbibla]

i opened a new issue to discuss "forgetting" #4751