Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replicating the results - MAPE #11

Open
Sepidehabol opened this issue May 19, 2022 · 7 comments
Open

replicating the results - MAPE #11

Sepidehabol opened this issue May 19, 2022 · 7 comments

Comments

@Sepidehabol
Copy link

Hello Prof. Lu!
I am trying to replicate the results in Fig S1 A for which I am running the validation_model("sigma_y", 10) varying the train size 10 to 20, 30, ..., 10,000 manually each time I run it.
image

My question is whether the MAPE on the y-axis in Fig S1 A is the mean value of the MAPE as the output of the validation_model. Running the model for tain_size=10 I get the mean value=1274.4625 which is not in the order of magnitude of MAPE in Fig S1 A. I have run it for tain_size up tp 100 and no close value to what it is in Fig S1 A. I would appreciate your response on this please.

image

Result:
sigma_y 10
1274.4625 689.9193

I have the same issue with Fig S1 B.

@Shatom
Copy link

Shatom commented May 19, 2022

I also run into the same problem.

@lululxvi
Copy link
Owner

Did you use the DeepXDE version mentioned at https://github.com/lululxvi/deep-learning-for-indentation#code?

@Sepidehabol
Copy link
Author

Thank you. I am using version 1.1.2 and still getting very high mean values of MAPE.
Also, running the Validation_FEM (trying to replicate Fig 2B), the MAPE values are of the order 1000.
I appreciate your advice on this.

@Shatom
Copy link

Shatom commented May 20, 2022

Thank you, Lu lu. I am using the version 0.14.1.
I set the set standardize=True in dde.data.DataSet(), not the dde.data.MfDateSet(),
and it seems ok with MAPE under order 100, for both Fig S1 B and Fig 2 B.
Thank you for your information.

@Sepidehabol
Copy link
Author

I did the same although my version is 1.1.2 and now it seems working. Thank you!

@lululxvi
Copy link
Owner

@Shatom Do you mean that you resolved the issue and it works?

@Shatom
Copy link

Shatom commented May 22, 2022

@lululxvi Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants