Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for math/bits methods #7

Open
lukechampine opened this issue Oct 2, 2020 · 4 comments
Open

Add tests for math/bits methods #7

lukechampine opened this issue Oct 2, 2020 · 4 comments
Labels
hacktoberfest

Comments

@lukechampine
Copy link
Owner

lukechampine commented Oct 2, 2020 •
edited
Loading

The following methods are missing test coverage:

  • TrailingZeros
  • OnesCount
  • RotateLeft
  • RotateRight
  • Reverse
  • ReverseBytes
  • Len

Ideally, you should copy the test cases from math/bits: https://golang.org/src/math/bits/bits_test.go (specifically, you'll probably want to use the tab array from the bottom of the file).

Feel free to submit tests for all of these, or just one. You can also convert the existing LeadingZeros test to match the testing format used in math/bits.
@satyabansahoo2000
Copy link
Contributor

@lukechampine Can you assign that to me? I will do it.

@lukechampine
Copy link
Owner Author

Sure, go for it!

@satyabansahoo2000
Copy link
Contributor

Please, take a look at this. #8
If anything needed to be removed or added, inform me.

@lukechampine
Copy link
Owner Author

@tomaszjonak @cvhariharan @pedroandrade anyone willing to take this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukechampine @satyabansahoo2000