Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MEMBER and RELATED Properties #273

Open
minch4 opened this issue Aug 25, 2020 · 6 comments
Open

Add MEMBER and RELATED Properties #273

minch4 opened this issue Aug 25, 2020 · 6 comments

Comments

@minch4
Copy link

minch4 commented Aug 25, 2020

Hello =)

if anyone has time for the implementation of :

it would be nice
=D

@lucc
Copy link
Owner

lucc commented Aug 27, 2020

I am open to pull request.

@dinojr
Copy link

dinojr commented Feb 19, 2021

As noted in this vdirsyncer issue, the combination google contacts + vdirsyncer doesn't properly handle these fields and creates item1.X-ABRELATEDNAMES and matching item1.X-ABLabel field but khard item1.X-ABRELATEDNAMES:name_of_the_child or khard name_of_the_child doesn't find the contact.

@d7415
Copy link
Contributor

d7415 commented Feb 19, 2021

google contacts + vdirsyncer doesn't properly handle these fields and creates item1.X-ABRELATEDNAMES and matching item1.X-ABLabel field

Google seems to do this their end - if you do a Takeout as VCF it will use this form.

but khard item1.X-ABRELATEDNAMES:name_of_the_child or khard name_of_the_child doesn't find the contact.

khard name_of_the_child should list the contact - my khard does. khard show name_of_the_child should show the full contact. What version of khard are you using?

@dinojr
Copy link

dinojr commented Feb 19, 2021

khard name_of_the_child should list the contact - my khard does. khard show name_of_the_child should show the full contact. What version of khard are you using

I tried with the v0.17.0. from Ubuntu and Khard version 0.17.1.dev47+g57b5bbc from git, still not showing with python -m khard name_of_the_child. The card of the mother (with the item.X-AB*** field in it) is found when looking for her name, and some other cards bearing the same name as the child looked for are found by khard name_of_the_child though. I tried changing the child name name in the vcf file to something unique among my vcards but it wasn't found either.

@d7415
Copy link
Contributor

d7415 commented Feb 19, 2021

Ok. I just checked again with 57b5bbc (I was a little behind) and I'm still getting correct results. I've tried with several of my contacts with item1.X-ABRELATEDNAMES style fields and all are working fine.

Does yours work with this minimal VCARD?

BEGIN:VCARD
VERSION:3.0
UID:bgd94fikayue7f0yn88fk9d4w1v3sxuov17m
FN:John Smith
N:Smith;John;;;
REV:20210219T111150Z
item1.X-ABLABEL:Child
item1.X-ABRELATEDNAMES:Jenny
END:VCARD

Edit: This should probably be broken out into its own issue as it's now a bug report unrelated to the initial feature request.

@dinojr
Copy link

dinojr commented Feb 19, 2021

With your example vcf file, Khard 0.17.1.dev47+g57b5bbc, picks up john smith but not jenny. I'll open a different issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants