Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating a card, formatted name alone is not accepted #239

Open
hydrargyrum opened this issue Dec 27, 2019 · 2 comments
Open

When creating a card, formatted name alone is not accepted #239

hydrargyrum opened this issue Dec 27, 2019 · 2 comments

Comments

@hydrargyrum
Copy link

Following #171 the FN field (formatted name, full name) field is now accepted and it can be generated from N field.
However, when submitting a new card (with khard new) setting only "formatted name" and "email", no "first name", "last name", the card is rejected, see https://github.com/scheibler/khard/blob/master/khard/carddav_object.py#L1031
That card should be accepted, and the FN and emails fields be set.

@lucc
Copy link
Owner

lucc commented Jan 6, 2020

I think this was originaly a safety mesure to enure that the FN field could be generated. Maybe we can modify the logic in khard to do less checks ourself and use the validation from vobject instead.

@lucc
Copy link
Owner

lucc commented Jul 20, 2020

PRs welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants