Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CI/CD Pipeline #113

Open
haraldhob opened this issue Apr 11, 2023 · 7 comments
Open

Create CI/CD Pipeline #113

haraldhob opened this issue Apr 11, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@haraldhob
Copy link

Hello @lucanaef,

we are two students from KTH Stockholm and are participating in a DevOps course. One of our assignments is a DevOps related contribution in an open source project. We would like to participate in PGPro and propose to develop a CI/CD pipeline with the following content:

  • Lint Checks
  • Unit Tests
  • UI Tests
  • Deployment to the Apple AppStore
  • Screenshot generation

Would you be interested in such a contribution?
Thank you in advance for your answer!

@lucanaef
Copy link
Owner

Sure, sounds great!

@lucanaef lucanaef added the enhancement New feature or request label Apr 13, 2023
@haraldhob
Copy link
Author

WIP Update:
We will start working now on creating the CI/CD Pipeline. We will create a fork and work on a separate branch there to create a pull request. First tasks will be building the swift project and running tests.

@luisjira
Copy link

luisjira commented May 4, 2023

@lucanaef we're currently working on the deployment to the AppStore. Do you want this to happen on every push to the master branch or on a new release tag?
The current deployment workflow is defined here: https://github.com/haraldhob/PGPro/blob/feature/cicd/.github/workflows/deployment.yml

We also noticed that the develop branch is more active at the moment. Which branch would you prefer us to open a pull request for?

@lucanaef
Copy link
Owner

lucanaef commented May 4, 2023

I'd say on a new release tag. Please open the pull request to develop, I'll then merge it into main later.

@luisjira
Copy link

luisjira commented May 4, 2023

Okay, I just changed the workflow trigger to a "released" release tag.

Currently, we also have a workflow configured to release a beta version to TestFlight on every push to develop. Would you prefer this to trigger on a "prereleased" release tag?

A release tag with the action type "prereleased" is defined here as:

A release was created and identified as a pre-release. A pre-release is a release that is not ready for production and may be unstable.

@lucanaef
Copy link
Owner

lucanaef commented May 5, 2023

I like your current workflow configuration with tags for releases and continuous beta builds on pushes to develop.

@luisjira
Copy link

luisjira commented May 8, 2023

We have now created #118 for you to review our changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants