Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TensorBoardWSGIApp method signature changed in tf 2.0 #56

Merged
merged 4 commits into from
Feb 16, 2020
Merged

fix TensorBoardWSGIApp method signature changed in tf 2.0 #56

merged 4 commits into from
Feb 16, 2020

Conversation

qrtt1
Copy link
Contributor

@qrtt1 qrtt1 commented Oct 4, 2019

tensorboard make some changes, it causes jupyter_tensorboard open failure

  1. refactor and remove method tensorflow/tensorboard@f06f40b
  2. add method and introduce data-provider
    tensorflow/tensorboard@f145659

for jupyter-tensorboard, it could use different arguments to a specific tensorboard version

@qrtt1 qrtt1 changed the title fix TensorBoardWSGIApp method signature changed fix TensorBoardWSGIApp method signature changed in tf 2.0 Oct 5, 2019
@juliusvonkohout
Copy link

juliusvonkohout commented Oct 16, 2019

@lspvic Please merge and release

grafik

less dependency is better
@davidrpugh
Copy link

@lspvic Thanks for putting together this awesome JupyterLab extension! Any idea when/if this PR might be merged?

@lspvic lspvic merged commit 953375e into lspvic:master Feb 16, 2020
@nfelt nfelt mentioned this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants