Support hparams plugin via Tensorboard POST api handler. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add handler for POST requests to TensorboardHandler, providing support for hparams plugin.
Expand xsrf_cookie exceptions, normally only applied to GET and HEAD requests in the IPythonHandler, to POST requests in TensorboardHandler. Provides support for hparams plugin, which uses POST to retrieve experiment information but can't be trivially extended to include xsrf information in these POST requests. Mirrors existing IPythonHandler behavior, falling back to Referer header rather than form parameters.
cliffwoolley
added a commit
to cliffwoolley/jupyter_tensorboard
that referenced
this pull request
Feb 17, 2021
Merges and adapts changes from lspvic#54 to fix TensorBoard 2.4.x scalar card compatibility Signed-off-by: Cliff Woolley <jwoolley@nvidia.com>
cliffwoolley
added a commit
to cliffwoolley/jupyter_tensorboard
that referenced
this pull request
Feb 25, 2021
Extends XSRF header exceptions to POST requests per discussion in tensorflow/tensorboard#4685 (comment) Signed-off-by: Cliff Woolley <jwoolley@nvidia.com>
cliffwoolley
added a commit
to cliffwoolley/jupyter_tensorboard
that referenced
this pull request
Feb 25, 2021
Extends XSRF header exceptions to POST requests per discussion in tensorflow/tensorboard#4685 (comment) Signed-off-by: Cliff Woolley <jwoolley@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Tensorboard hparams plugin, included in tensorboard 1.14+,
uses POST requests to access experiment information. The 0.1.10
of jupyter_tensorboard only provides a GET handler, breaking the
hparams Tensorboard view.
Expand TensorboardHandler to include both GET and POST actions
and extended xsrf_cookie exceptions, normally only applied to GET
and HEAD requests in the IPythonHandler, to POST requests in
TensorboardHandler.
Provides support for hparams plugin, which uses POST to retrieve
experiment information but can't be trivially extended to include xsrf
information in these POST requests. Mirrors existing IPythonHandler
behavior, falling back to Referer header rather than form parameters.