Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
First of all, thanks for making this project. I've found it really useful.
I have a use case where I want to specify a logging directory for Tensorboard that is outside of the current Jupyter root directory. I wasn't able to find a way to do this with the existing UI, so I made a fork and added something myself. I thought I would make a pull request in case you think it might be useful to other people.
Here's how it works. Now from the "New" menu in Jupyter you can select either Current Directory or Custom Directory:
Selecting Custom Directory brings up a modal with a text field into which any path can be entered
This creates the Tensorboard instance with the supplied path being used as the logging directory.
The main thing missing at the moment I would say is that it doesn't do any validation on the filepath supplied by the user, so for example you can create a Tensorboard instance that uses a non-existent directory as its logging directory (maybe that's useful if the directory gets created during model training or something?).
Other things: maybe rather than the dropleft submenu, there should just be another section to the original dropdown titled "Tensorboard", like there currently is "Notebooks" and "Other". Also I didn't add any tests, but it's probably worth doing so. Happy to take guidance on that.
Happy for you to say whether you think any of those are important to add or whether they can wait to a future update.
Anyway, let me know if you think this is something that's worth adding.