This repository has been archived by the owner on Apr 23, 2023. It is now read-only.
Location provider enabled/disabled #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahsnow1
force-pushed
the
123-on-provider-changed
branch
from
7a85ec3
to
c99fd5d
Compare
ecgreb
reviewed
Nov 9, 2016
| @@ -1,6 +1,7 @@ | |||
| package com.mapzen.android.lost.api; | |||
|
|
|||
| import android.location.Location; | |||
| import android.os.Looper; | |||
There was a problem hiding this comment.
:lost:checkstyle[ant:checkstyle] /home/ubuntu/lost/lost/src/main/java/com/mapzen/android/lost/api/LocationListener.java:4:8: Unused import - android.os.Looper.
ecgreb
suggested changes
Nov 9, 2016
|
|
||
| private void checkLocationAvailability() { | ||
| LocationAvailability availability = | ||
| LocationServices.FusedLocationApi.getLocationAvailability(client); |
There was a problem hiding this comment.
While exercising a call to FusedLocationApi.getLocationAvailability(client) is good we should also verify that LocationCallback is properly invoked when location updates have been requested and provider status changes occur.
This is the use case that would more suitably replace LocationListener.onProviderEnabled(String provider) and LocationListener.onProviderDisabled(String provider) since the client app is relying on a push style notification rather than actively polling the provider status.
ecgreb
reviewed
Nov 9, 2016
| @@ -17,14 +18,28 @@ | |||
| void onLocationChanged(Location location); | |||
|
|
|||
| /** | |||
| * Called when a location provider is disabled. | |||
| * Called when a location provider is disabled. You will only receive updates for the priority | |||
added 6 commits
November 9, 2016 13:58
ecgreb
approved these changes
Nov 11, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR changes the underlying mechanism that Lost uses to notify of providers enabled/disabled from a
LocationListenerto aContentObserveron the system location provider setting.Proposed Changes
FusionEngineno longer does anything with its provider changedLocationListenermethods and instead usesLocationProviderChangedHandlerto receive notifications of providers enabled & disabled. TheLocationProviderChangedHandlerhandles setting up aContentObserverto listen to changes toSettings.System.LOCATION_PROVIDERS_ALLOWED.Closes #123