Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update french translation #744

Merged
merged 5 commits into from
May 13, 2023
Merged

Update french translation #744

merged 5 commits into from
May 13, 2023

Conversation

FrankSAURET
Copy link
Contributor

No description provided.

@terales
Copy link
Collaborator

terales commented Apr 29, 2023

@FrankSAURET Sorry for the long waiting time. We're back on maintaining the project.

Would you be open to resolving the conflicts with translations?

@FrankSAURET
Copy link
Contributor Author

Conflicts resolved. :-)

Copy link
Collaborator

@terales terales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highlighted a few changes that look like typos. Can you take a look, please?

@Nicoxx45, @eri do the changes look good to you? (I love the switch to «»)

locales/fr.json Outdated Show resolved Hide resolved
locales/fr.json Outdated Show resolved Hide resolved
locales/fr.json Show resolved Hide resolved
locales/fr.json Show resolved Hide resolved
locales/fr.json Outdated Show resolved Hide resolved
locales/fr.json Outdated Show resolved Hide resolved
locales/fr.json Show resolved Hide resolved
@terales
Copy link
Collaborator

terales commented May 2, 2023

@FrankSAURET thanks for checking the comments! Can you implement the changes so I could merge them, please?

@eri
Copy link
Contributor

eri commented May 9, 2023

Hello @terales, sorry for the delay. I didn't notice your @ earlier. I've added a few comments on the points you requested me to review. Let me know if I could help!

@FrankSAURET
Copy link
Contributor Author

J'ai proposé de nouvelles correction qui reprennent ce que vous venez de dire.

@terales terales merged commit ffa0930 into lokalise:main May 13, 2023
huacnlee pushed a commit to huacnlee/i18n-ally that referenced this pull request Aug 28, 2023
…kalise#744)

Co-authored-by: Alex Terehov <terales@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants