Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(test): improve test coverage #1204

Merged
merged 5 commits into from
Mar 9, 2022
Merged

chore(test): improve test coverage #1204

merged 5 commits into from
Mar 9, 2022

Conversation

lamweili
Copy link
Contributor

@lamweili lamweili commented Mar 8, 2022 •
edited
Loading

Improve Test Coverage (Part 2 of 3)

Part Version/PR File % Stmts % Branch % Funcs % Lines Uncovered Line #s
log4js@6.4.2 All files 97.67 96.24 97.42 97.67
1/3 #1200 All files 98.62 97.91 98.51 98.56
2/3 #1204 All files 99.48 98.67 100 99.46
3/3 #1205 All files 100 100 100 100

@lamweili
chore(test): improve test coverage for fileSyncAppender
aa566df 
appenders/fileSync.js - Line 11 - return;
@lamweili
chore(test): improve test coverage for dateFileAppender
edc612e 
appenders/dateFile.js - Line 13 - console.error('log4js.dateFileAppender - Writing to file %s, error happened ', filename, err); // eslint-disable-line
@lamweili lamweili added the tests Test issues or coverage label Mar 8, 2022
@lamweili lamweili added this to the 6.4.3 milestone Mar 8, 2022
@lamweili lamweili marked this pull request as draft March 8, 2022 18:16
@lamweili
chore(test): improve test coverage for tcpAppender
633b422 
appenders/tcp.js - Line 37 - debug('drain event received, emptying buffer');
appenders/tcp.js - Line 38 - canWrite = true;
appenders/tcp.js - Line 39 - emptyBuffer();
appenders/tcp.js - Line 43 - debug('connection error', e);
appenders/tcp.js - Line 44 - canWrite = false;
appenders/tcp.js - Line 45 - emptyBuffer();
appenders/tcp.js - Line 54 - write(loggingEvent);
@lamweili lamweili mentioned this pull request Mar 9, 2022
Merged
@lamweili
chore(test): improve test coverage for fileAppender and dateFileAppender
c556a1a 
appenders/file.js     - Line 56 - process.emit("log4js:pause", false);
appenders/dateFile.js - Line 16 - process.emit("log4js:pause", false);
@lamweili
chore(test): increased timeout for multi-file-appender-test.js
0abf8a6
@lamweili lamweili marked this pull request as ready for review March 9, 2022 17:05
@lamweili lamweili merged commit 92507f7 into master Mar 9, 2022
@lamweili lamweili deleted the update-test branch March 9, 2022 17:05
@lamweili lamweili mentioned this pull request Mar 10, 2022
Merged
@myfreeer myfreeer mentioned this pull request Mar 16, 2022
Merged
@sync-by-unito sync-by-unito bot mentioned this pull request Mar 16, 2022
Closed
@renovate renovate bot mentioned this pull request Mar 22, 2022
Merged
1 task
@sync-by-unito sync-by-unito bot mentioned this pull request Mar 22, 2022
Closed
This was referenced Apr 22, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests Test issues or coverage
Projects
None yet
Milestone
6.4.3
Development

Successfully merging this pull request may close these issues.
1 participant
@lamweili