Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repeated imports of mock #936

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

Jonnymcc
Copy link
Contributor

I am not sure why mock is imported multiple times but the tests pass even without them. If there is a good reason to keep them then this could be closed. Otherwise for readability I think they should be removed.

@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #936 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #936   +/-   ##
=======================================
  Coverage   66.55%   66.55%           
=======================================
  Files          14       14           
  Lines        1438     1438           
  Branches      226      226           
=======================================
  Hits          957      957           
  Misses        430      430           
  Partials       51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a155ed...52419a0. Read the comment docs.

@aldenpeterson-wf
Copy link
Contributor

I'm fine with this, I'd guess what happened was:

  1. A single test got written with the inline import
  2. That test got copied everywhere
  3. Someone realized "hey we can global import"
  4. Step 2 never got cleaned up

@cgoldberg
Copy link
Member

LGTM

@cgoldberg cgoldberg merged commit 7810cf8 into locustio:master Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants