Python37 #885
Merged
Python37 #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis CI slave doesn't have 3.7 installed |
mbeacom
reviewed
Sep 18, 2018
| @@ -3,6 +3,8 @@ language: python | |||
| cache: pip | |||
| matrix: | |||
| include: | |||
| - python: 3.7 | |||
There was a problem hiding this comment.
@cgoldberg You can get travis to run this via something like:
include:
- python: 3.7
env: TOXENV=py37
dist: xenial
sudo: true
Codecov Report
@@ Coverage Diff @@
## master #885 +/- ##
=======================================
Coverage 66.55% 66.55%
=======================================
Files 14 14
Lines 1438 1438
Branches 226 226
=======================================
Hits 957 957
Misses 430 430
Partials 51 51Continue to review full report at Codecov.
|
|
@cgoldberg It should pass if you add |
|
@mbeacom thanks! merging this now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Python 3.7 support