Fix frontend bugs. #822
Merged
Fix frontend bugs. #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @omittones ! Is this still relevant? |
|
No idea, haven't used locust in a while. Will see tomorrow and close it if
it's not.
…On Fri, Oct 18, 2019, 23:05 Lars Holmberg ***@***.***> wrote:
Hi @omittones <https://github.com/omittones> ! Is this still relevant?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#822?email_source=notifications&email_token=AAJNDFVILKL4TI63PJVUV4LQPIQKFA5CNFSM4FFUCPH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBV7JCA#issuecomment-543945864>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJNDFRHK3UUVFPV4MRHCPLQPIQKFANCNFSM4FFUCPHQ>
.
|
Codecov Report
@@ Coverage Diff @@
## master #822 +/- ##
==========================================
+ Coverage 71.19% 72.48% +1.29%
==========================================
Files 17 17
Lines 1701 1701
Branches 253 253
==========================================
+ Hits 1211 1233 +22
+ Misses 429 406 -23
- Partials 61 62 +1
Continue to review full report at Codecov.
|
Hey, I merged with master and this is still relevant. It includes a fix for error happening on frontend, and minor refactoring. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Console error while sorting the table (report is undefined). Extracted code for rendering the table.