Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping the logging setup #738

Merged
merged 5 commits into from
Oct 20, 2019
Merged

Conversation

Exide
Copy link
Contributor

@Exide Exide commented Feb 22, 2018

New CLI option:

--skip-log-setup

This would allow people to setup their own logging configuration. It would also provide a workaround for #163.

@codecov
Copy link

codecov bot commented Feb 22, 2018

Codecov Report

Merging #738 into master will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #738      +/-   ##
==========================================
- Coverage    66.1%   66.08%   -0.03%     
==========================================
  Files          14       14              
  Lines        1422     1424       +2     
  Branches      224      225       +1     
==========================================
+ Hits          940      941       +1     
- Misses        431      432       +1     
  Partials       51       51
Impacted Files Coverage Δ
locust/main.py 26.38% <33.33%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b43c7...9dadbac. Read the comment docs.

@Exide
Copy link
Contributor Author

Exide commented Feb 22, 2018

I've not used Codecov before so I'm finding it difficult to understand what threshold I need to meet. Let me know what is needed and I'll rectify it.

@neg3ntropy
Copy link

I was trying to use pudb to do some simple debugging, but it fails to open the console interface due to the wrapping of standard error/output

@Exide
Copy link
Contributor Author

Exide commented Jun 18, 2018

@soulrebel This PR would allow you to skip the call to log.setup_logging which is where that wrapper is established.

@SpencerPinegar
Copy link

This should be merged with the code base -- vital when testing code or else the unittestpy.py with error out with -- 'StdOutWrapper' object has no attribute 'getvalue' -- if this functionality could be incorporated into the wrapper that would be cool, but it looked like the getvalue function had other dependencies within the unittestpy.py module.

@aldenpeterson-wf
Copy link
Contributor

This LGTM.

Anyone have objections to me merging this?

@tally38
Copy link

tally38 commented Jun 12, 2019

Also ran into this issue, and would like this to be merged!

@cyberw cyberw merged commit 668b8a3 into locustio:master Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants